search

messagebird / csharp-rest-api

This repository contains the open source C# client for MessageBird's REST API.
ISC License
54 stars 60 forks source link

Remove the whatsapp sandbox functionality #87

Closed jagjeetdhaliwal closed 3 years ago

jagjeetdhaliwal commented 3 years ago

The WhatsApp Sandbox has been properly integrated into Conversations API, so it shouldn't be accessed directly.

ahmetkocadogan commented 3 years ago

@jagjeetdhaliwal Is this a community contribution?

jagjeetdhaliwal commented 3 years ago

@ahmetkocadogan No :) Just updating the SDK internally to remove some of the functionality. Essentially reverting - https://github.com/messagebird/csharp-rest-api/pull/61

ahmetkocadogan commented 3 years ago

@jagjeetdhaliwal ok :) This will be a breaking change for my bot framework adapter, that's why I ask. I'll keep tracking nuget release of this sdk. https://github.com/BotBuilderCommunity/botbuilder-community-dotnet/tree/develop/libraries/Bot.Builder.Community.Adapters.MessageBird

rjelierse commented 3 years ago

@ahmetkocadogan hi :-) I'm the dev that wrote the Sandbox. You should be able to continue using the SDK without the feature toggle (that's the only change), the underlying API will function as is. We only needed the flag, because at the time, the WhatsApp Sandbox was a PoC and not yet integrated into the Conversations API. I think the same will apply to your bot adapter. You could choose to simply ignore the value on the adapter options if you don't want to introduce a breaking change.

ahmetkocadogan commented 3 years ago

@rjelierse Hello. I tried it without the flag and I couldn't use whatsapp sandbox, it was yesterday after I see this PR.

My adapter is already released via nuget, so I'll update it when you make a new release of this c# sdk.

ahmetkocadogan commented 3 years ago

@rjelierse I reflected this update to my adapter.

https://github.com/BotBuilderCommunity/botbuilder-community-dotnet/pull/342

fyi.

ahmetkocadogan commented 3 years ago

@rjelierse can you kindly check this issue https://github.com/messagebird/csharp-rest-api/issues/89 ?

WhatsApp sandbox does not work with v3 of this sdk.