messagebird / java-rest-api

This repository contains the open source Java client for MessageBird's REST API.
https://www.messagebird.com/developers/java
BSD 3-Clause "New" or "Revised" License
48 stars 80 forks source link

Fix unit tests when running from the command line on a fresh setup #62

Open dangg opened 5 years ago

dangg commented 5 years ago

Situation: According to the documentation at https://github.com/messagebird/java-rest-api/blob/master/README.md running the command

mvn test -Ptest -DmessageBirdAccessKey=[your access key] -DmessageBirdMSISDN=[your phone]

should run the tests, however the tests are skipped

The issue seems to come from the configuration under the default profile

default false Before changing this we need to ensure we don't break something else (such as builds)
rvt commented 4 years ago

Perhaps it makes sense to split the tests that require DmessageBirdAccessKey and DmessageBirdMSISDN and move these to integration tests. While leaving the pure unit tests in place.