search

messagebird / php-rest-api

This repository contains the open source PHP client for MessageBird's REST API.
https://developers.messagebird.com/
BSD 2-Clause "Simplified" License
158 stars 95 forks source link

Move from TravisCI to Github Actions. #134

Closed lucasmichot closed 3 years ago

lucasmichot commented 3 years ago

This PR moves tests from TravisCI to Github Actions.

Also, the need for a separate composer.json is removed, by simply setting up a new phpunit version constraint.

@bviolier, I guess that the Github Actions need to be enabled for this repository.

rfeiner commented 3 years ago

Thanks @lucasmichot! GH Actions is already enabled, we will have a look at this PR.

lucasmichot commented 3 years ago

This is strange @rfeiner as https://github.com/messagebird/php-rest-api/actions displays no workflow run. As a comparison, you can see the ones that have run for my fork of this repository, for this specific PR: https://github.com/lucasmichot/php-rest-api/actions

Side-note, https://github.com/messagebird/php-rest-api/pull/134/commits/08a69b6aa101c8ba6adfa4e19af3d9fbc6a208cb was forced pushed to attempt a re-trigger of the workflow provided in this PR.

Here are my settings that you might want to compare with the ones of this repository:

image

rfeiner commented 3 years ago

We will merge the PR. I believe the actions are not running because your branch is not living in GitHub's messagebird/php-rest-api namespace