messagebird / pushprom

Pushprom is a proxy to the Prometheus Go client.
https://www.messagebird.com
BSD 2-Clause "Simplified" License
80 stars 13 forks source link

OBSV-443 messagebird/pushprom does not respect log-level argument #32

Open sshilko opened 1 year ago

sshilko commented 1 year ago

The problem

Pushprom 1.0.8 is too verbose on default INFO level.

Trying to use the “documented” -log-level argument for the application does not have effect.

Update from 1.0.7 to 1.0.8 resulting in thousands unnecessary log records polluting the INFO logs.

Definition of Done

Pushprom 1.0.8 does not change behaviour when updating from 1.0.7 for logging.

or Pushprom 1.0.8 default verbosity level changes to “warn” and/or respect the -log-level documented argument.

https://github.com/messagebird/pushprom/tree/1.0.8

sshilko commented 1 year ago

I will submit the MR with the fix myself :)

sshilko commented 1 year ago

Please review https://github.com/messagebird/pushprom/pull/33

Behaviour change: