search

messagebird / ruby-rest-api

MessageBird's REST API for Ruby
BSD 2-Clause "Simplified" License
37 stars 46 forks source link

Raise InvalidPhoneNumberException instead of TypeError #10

Closed elhu closed 7 years ago

elhu commented 7 years ago

Hi!

This PR is the implementation of the fixed proposed in #9. It provides an actual exception class for lookups of invalid phone numbers.

It's still kind of an abuse of the TypeError ancestor, but I believe it's much closer to the intended behaviour that what is currently live in the gem.

PS: Back in #9, you mentioned plans for a major update of the ruby client. Is that still in the plans?

cooldarkdryplace commented 7 years ago

Hi @elhu

Thanks for your PR, we will review it and get back to you! @samwierema can you please tell if we have Ruby client major update planned?