make MessageBird::ErrorException a StandardException

messagebird / ruby-rest-api

MessageBird's REST API for Ruby

BSD 2-Clause "Simplified" License

37 stars 46 forks source link

Closed Hampei closed 8 years ago

Hampei commented 8 years ago

Non StandardExceptions are reserved for the really really bad stuff like syntax errors and memory issues.

samwierema commented 8 years ago

Thank you for the pull request @hampei!

Did you mean StandardError instead of StandardException?

Hampei commented 8 years ago

So sorry, yes indeed. Fixed to StandardError.

samwierema commented 8 years ago

We'll be reviewing your pull request tomorrow.

samwierema commented 8 years ago

Merged. Thanks for improving our Ruby client @hampei!

Hampei commented 8 years ago

Thanks.