search

messagebird / ruby-rest-api

MessageBird's REST API for Ruby
BSD 2-Clause "Simplified" License
37 stars 46 forks source link

upgrade deps #75

Closed marcelcorso closed 2 years ago

marcelcorso commented 2 years ago

on https://github.com/messagebird/ruby-rest-api/pull/74 we added github actions but we didn't manage to pass tests. on https://github.com/messagebird/ruby-rest-api/pull/76 we made them pass with old ruby targets.

on this PR I try to modernise ✨ things like target new rubies on rubocop or raise gem limits of rubocup and rspec.

marcelcorso commented 2 years ago

Yes. But we should fix them anyway. If we do a major version release it's ok

On Sun, Apr 3, 2022, 10:14 Jalerson Lima @.***> wrote:

@.**** commented on this pull request.

In lib/messagebird/callflow.rb https://github.com/messagebird/ruby-rest-api/pull/75#discussion_r841183985 :

@@ -26,7 +26,8 @@ def updated_at=(value) end

class CallFlowList < List

  • attr_accessor :perPage, :currentPage, :pageCount, :totalCount

Aren't these breaking changes?

— Reply to this email directly, view it on GitHub https://github.com/messagebird/ruby-rest-api/pull/75#pullrequestreview-929641155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEZOWVFM7KNURFBXIFMU3VDFHNDANCNFSM5SEVC3FA . You are receiving this because you authored the thread.Message ID: @.***>

jalerson commented 2 years ago

@marcelcorso if we're going to go with a major release, let's ship this one as well? It fixes https://github.com/messagebird/ruby-rest-api/issues/22

marcelcorso commented 2 years ago

@jalerson yes!