messagebird / ruby-rest-api

MessageBird's REST API for Ruby
BSD 2-Clause "Simplified" License
37 stars 46 forks source link

Fix channel id typo in conversation methods #87

Open caiopardal opened 1 year ago

caiopardal commented 1 year ago

TL.DR. This PR fixes this issue

Issue

Based on MessageBird's Conversations API documentation, the start_conversation method should use a parameter named ChannelId, but at the client.rb file, it's being passed a channel_id param that generates a MessageBird::ServerException when trying to use the start_conversation method

Solution

As mentioned in the referenced issue, the solution was just to change and fix the typo at the channel_id parameter: channel_id -> ChannelId, exactly the same as in the documentation.

Also fixed the tests to ensure that the change works as expected