dzyanis
commented
2 years ago Hey!
1/ Just comment the test case alerts labels and leave TODO like that:
[image: image.png]
I will fix it later
2/ You need to add t.Parallel() line in the begging of the test
3/ If some linter just broke something and you don't know how to fix that it's okay just disable it and back to the problem later. They are not so critical
have a nice day
On Fri, Mar 18, 2022 at 11:55 AM marcel corso gonzalez < @.***> wrote:
hey @dzyanis https://github.com/dzyanis ! I found a problem.
In this PR I'm running the tests and this is breaking
https://github.com/messagebird/sachet/runs/5597776654?check_suite_focus=true#step:5:33 sometimes.
I think it's because when you iterate over a map the order is random. See https://go.dev/blog/maps#iteration-order
Can you help me fix it? I'm not sure how 🙏🏽
Also I'm not sure the lint is running according to the configuration. It passed on this run https://github.com/messagebird/sachet/runs/5597776651?check_suite_focus=true#step:4:74 but it tried to make a mistake on purpose here: 22909da https://github.com/messagebird/sachet/commit/22909da5db5359968c58c08cf0501424db6594d4
— Reply to this email directly, view it on GitHub https://github.com/messagebird/sachet/pull/113#issuecomment-1072205648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFBV3O2H2WE3YPTXM7IW43VARAGZANCNFSM5RBFEOTQ . You are receiving this because you were mentioned.Message ID: @.***>
-- Dzyanis Kuzmenka Mobile: +375 29 196-28-94 LinkedIn: linkedin.com/in/dzeveloper https://www.linkedin.com/in/dzeveloper Github: github.com/dzyanis
hey @dzyanis ! I found a problem.
In this PR I'm running the tests and this is breaking https://github.com/messagebird/sachet/runs/5597776654?check_suite_focus=true#step:5:33 sometimes.
I think it's because when you iterate over a map the order is random. See https://go.dev/blog/maps#iteration-order
Can you help me fix it? I'm not sure how 🙏🏽
Also I'm not sure the lint is running according to the configuration. It passed on this run https://github.com/messagebird/sachet/runs/5597776651?check_suite_focus=true#step:4:74 but it tried to make a mistake on purpose here: https://github.com/messagebird/sachet/pull/113/commits/22909da5db5359968c58c08cf0501424db6594d4