Add Mail.ru Instant Messengers provider

messagebird / sachet

SMS alerts for Prometheus' Alertmanager

https://www.messagebird.com

BSD 2-Clause "Simplified" License

216 stars 89 forks source link

Add Mail.ru Instant Messengers provider #94

Closed DrGonzo closed 3 years ago

marcelcorso commented 3 years ago

hey @DrGonzo ! Wow ICQ! That's epic. Thank you.

Are you sure you want to use Mail.ru IM as a name for structs, configs and not ICQ? Because mail.ru IM is also comprised of TamTam and Agent per their website. And you are using the icq api to send the messages...

Another question: it's hard for us to test every provider. Did you test this in production? To send a message?

thanks!

DrGonzo commented 3 years ago

Mail.ru messengers ICQ(yep, icq over 10 year belongs to mail.ru), Agent and MyTeam now uses same protocol/api and i use official "mail-ru-im/bot-golang" lib (so i think "mail.ru im" less known but more fairly name) which says what override bot's API URL changes messenger. I adds "api.icq.net" as default in PR example config, but tested with internal "MyTeam" api url.

marcelcorso commented 3 years ago

Oh I get it. It's a good idea to use the same protocol. Ok! Let's merge this. Thanks again for the PR.