search

messageformat / Jed

Gettext Style i18n for Modern JavaScript Apps
http://messageformat.github.io/Jed
MIT License
873 stars 68 forks source link

Add meaningful error messages #41

Open atimmer opened 8 years ago

atimmer commented 8 years ago

I was bitten by [sprintf] huh?, this should make debugging for other people much easier.

atimmer commented 8 years ago

Another possibility would be depending on https://github.com/alexei/sprintf.js which looks at lot like the inline sprintf-implementation.

SlexAxton commented 8 years ago

It is the alexei implementation, just inlined. Feel free to just re-inline the latest.

atimmer commented 8 years ago

Wouldn't it be better to depend on it in the package.json? This means updates in the future will be easier to incorporate. I am willing to do this work.

SlexAxton commented 8 years ago

Happy to take a PR. It works like it currently does because I released Jed in 2012 and sprintf wasn't on Github until 2013. It was just a file on his website.