Missing dependency - com.mashape.unirest:unirest-java

messagemedia / messages-java-sdk

MessageMedia Java SDK for sending and receiving messages

https://developers.messagemedia.com/

Apache License 2.0

7 stars 7 forks source link

Missing dependency - com.mashape.unirest:unirest-java #7

Open philBrown opened 5 years ago

philBrown commented 5 years ago

Was trying to have a go with your API after having a chat with the lovely folk at your YOW! booth in Melbourne and immediately ran into this error using v1.2.0

Exception in thread "main" java.lang.NoClassDefFoundError: com/mashape/unirest/request/HttpRequest
    at com.messagemedia.messages.controllers.BaseController.getClientInstance(BaseController.java:81)

This com.mashape.unirest package is used in

src/main/java/com/messagemedia/messages/http/client/UnirestClient.java, and
src/main/java/com/messagemedia/messages/APIHelper.java

but the package isn't part of this project or any of its dependencies.

Cheers

gaaliprabhakar commented 5 years ago

Hi, what is the release date for this issue fix?

Thanks

coderbec commented 5 years ago

Hi, Unirest get's pulled in from the jitpack repo and should be the first dependency. HAve looked into some of the issues that people have been having with this particular dependency and they seem to be related to the fact that its hosted on jitpack not on maven central. It's additionally a custom version of unirest. I will be pushing a version of this, this week, which no longer uses unirest (it will use square's okhttp).

philBrown commented 5 years ago

@coderbec I highly doubt it's got anything to do with the repo location since when this bug was raised, there was literally no dependency for unirest-java. You only added that on Jan 18 ~ https://github.com/messagemedia/messages-java-sdk/commit/c74588ec4ee98b2a58543299762607561b41ced5#diff-600376dffeb79835ede4a0b285078036R98