messagerie-melanie2 / Roundcube-Plugin-Mobile

Mobile plugin for Roundcube (used by Mobile skin)
GNU General Public License v3.0
40 stars 13 forks source link

From name overlapping, at message selection screen #20

Open twisterbr opened 7 years ago

twisterbr commented 7 years ago

If the name in the From header is big, it overlaps to the message below. Edit: I forgot to put the version info. Roundcube 1.1.1 Mobile Melanie2 Skin 0.4.3 jquery mobile 1.4.5

screenshot_2016-12-11-13-47-07

tpayen commented 7 years ago

I don't know if it's due to the pipe, because i've often long names that are shown in one line with the ellipsis

twisterbr commented 7 years ago

I forgot to put the version info. Roundcube 1.1.1 Mobile Melanie2 Skin 0.4.3 jquery mobile 1.4.5

I noticed this issue happens only if the from name string has the characters <> on it. If not, it cuts the string adding 3 dots at the end (if the string is bigger than screen of course).

tpayen commented 7 years ago

can you try with last version of mobile skin (0.4.7) ? https://github.com/messagerie-melanie2/Roundcube-Skin-Melanie2-Larry-Mobile/releases/tag/v0.4.7 https://github.com/messagerie-melanie2/Roundcube-Plugin-Mobile/releases/tag/v0.4.7

twisterbr commented 7 years ago

@tpayen tried just now with latest version and I get the same issue.

I did some tests and if the From field on the message header has invalid characters or an invalid email address inside the <>, the issue happens. So, if the From field is "Name LastName <name@domain>" the problem will happen (notice the invalid domain, without extension), and also for "Name LastName <name@domain.com >" (notice the space at the end).

m0ps commented 7 years ago

We have similar issue: image roundcube 1.2.3 melanie2/mobile dev-master e2ee6f0 melanie2/jquery_mobile dev-master ea5fb49

tpayen commented 7 years ago

@twisterbr thank you for this very good investigation. I think you put your finger on something, I look at it asap

@m0ps it desn't look like the same issue, you probably have this because you didn't use same version between mobile plugin and melanie2_larry_mobile skin. Please use releases (0.4.7 for plugin and skin, 1.0 for jquery_mobile) to avoid this kind of problem

m0ps commented 7 years ago

@tpayen plugin and skin installed via composer according info provided in The Official Plugin Repository. composer.json quote:

"melanie2/mobile": "dev-master" "melanie2/jquery_mobile": "dev-master"

what the propper value for version field?

m0ps commented 7 years ago

Problem 1

  • The requested package melanie2/jquery_mobile ~0.4.7 exists as melanie2/jquery_mobile[dev-master] but these are rejected by your constraint. Problem 2
  • The requested package melanie2/mobile ~0.4.7 exists as melanie2/mobile[dev-master, dev-version-0.4.5] but these are rejected by your constraint.
tpayen commented 7 years ago

Unfortunately there is no composer for roundcube skins. So you have to take the last version of the skin from github

m0ps commented 7 years ago

but, what is this: https://plugins.roundcube.net/packages/melanie2/mobile https://plugins.roundcube.net/packages/melanie2/jquery_mobile ?

tpayen commented 7 years ago

There is 3 things for the mobile :

m0ps commented 7 years ago

Oh... I understood my mistake. Thx