messagerie-melanie2 / Roundcube-Plugin-Mobile

Mobile plugin for Roundcube (used by Mobile skin)
GNU General Public License v3.0
39 stars 13 forks source link

melanie2/Roundcube-Plugin-Mobile no more works with new beta version 1.3.0 of Roundcube #25

Open Melkin1968 opened 7 years ago

Melkin1968 commented 7 years ago

Hello,

it seems as melanie2/Roundcube-Plugin-Mobile no more works with new beta version 1.3.0 of Roundcube. Could you please modify melanie2/Roundcube-Plugin-Mobile for new Roundcube version?

Thank you a lot!

tpayen commented 7 years ago

I look asap, but as it's a beta it will surely wait for the rc

gnadelwartz commented 7 years ago

Hi,

the rc is out since april and final can be expected in June. Any thing new about compatibility with RC 1.3?

tomsommer commented 7 years ago

Any ETA?

tpayen commented 7 years ago

The main problem is that this mobile skin is based on JQuery Mobile which doesn't seems maintained since a while, and as Roundcube 1.3.0 use a new JQuery version (3.X), this is incompatible with the last version of JQuery Mobile (1.4.5). I'll have to find a solution for this or cross the fingers for a new JQuery Mobile version until the official Roundcube elastic skin is out

gnadelwartz commented 7 years ago

https://blog.jquerymobile.com/2017/05/

since Mai/17 JQ Mobile 1.5 alpha is availible, is this compatible with JQ3.x?

tpayen commented 7 years ago

Indeed, this alpha version is available since January, unfortunately it doesn't seem compatible with the JQuery version used in Roundcube 1.3.0. And the fact that the alpha version has not changed since January does not encourage optimism

guylando commented 7 years ago

jquery mobile 1.5 is compatible with jquery 3: https://github.com/jquery/jquery-mobile/issues/8546#issuecomment-271163317

gnadelwartz commented 7 years ago

See also blog.jQuerymobile.com

tpayen commented 7 years ago

Indeed, the version is advertised as compatible. Unfortunately it's not as simple as a change of version otherwise it would already be done. I tried the 1.5 alpha version of jquery mobile and it doesn't work better. I've to take the time to work on this problem, but time is missing. The only solution for now is to use a RC 1.2.5

lv01jsi commented 6 years ago

Here is a fix of .js files for mobile skin while RoundCube 1.4 Elastic is coming... Tested with RC 1.3.4. Extract to corresponding directories... melanie2_larry_mobile_fix_for_RC1.3.zip

Nippey commented 6 years ago

Hi @lv01jsi, thank you for the patch! I tested it with both 1.3.3 abd 1.3.4 I tried it and everything works, but the visuals of the Folder-view seem to be broken (see attached image).

Thanks anyway, this is better than the desktop view ;)

screenshot_20180122-085633

gnadelwartz commented 6 years ago

@Nippey had the same issue, solved it be giving read access to all files in skins/melanie2_larry_mobile

image

do not forget to download and unzip https://github.com/messagerie-melanie2/Roundcube-Skin-Melanie2-Larry-Mobile/archive/master.zip in case its not already there

tpayen commented 6 years ago

@lv01jsi wow! thank you for that, it works well on rc 1.3.4! Do you want to make a PR to appear as a contributor?

@Nippey it can come from your layout configuration. If you use "widescreen" it breaks the list of messages, I have to update the mobile plugin to force the non-widescreen configuration on mobile.

Nippey commented 6 years ago

@tpayen : Awesome, that's it! Thank you!

I created a second account in roundcube pointing to the same inbox. This way I separate the settings for "Desktop" and "Mobile" ;)

judexzhu commented 6 years ago

@tpayen : Thank you so much !

Could you please tell me how can I set as you mentioned ?

I have to update the mobile plugin to force the non-widescreen configuration on mobile.

and I'm running the roundcube 1.3.0, it looks has a white stripe on the bottom , anyway I can fix it ? image

tpayen commented 6 years ago

@judexzhu you can use new releases 0.4.8 for mobile plugin and melanie2_larry_mobile skin, with v1.1 of jquery_mobile plugin. They implement the patch of lv01jsi for RC 1.3 and fix the "layout" problem (and probably the new message button display problem too).

fnxweb commented 6 years ago

Kudos, guys! Great job.

OpenAai commented 6 years ago

This is great guys! Thanks ever so much! :-)

tharick commented 6 years ago

Great job guys, thanks a lot :D