Leak in Session consumer tracking of closed pooled consumers

messaginghub / pooled-jms

A JMS Connection pool for messaging applications supporting JMS 1.1 and 2.0 and Jakarta JMS clients

Apache License 2.0

49 stars 25 forks source link

Leak in Session consumer tracking of closed pooled consumers #22

Closed tabish121 closed 3 years ago

tabish121 commented 3 years ago

When a pooled consumer is closed the pooled session is removing the wrong reference from its internal tracking leading to a leak whereby it retains a reference to the closed pooled consumer wrapper. The code needs to be tightened to avoid allowing this to happen and ensure that the pooled wrappers are removed properly.

AntonRoskvist commented 2 years ago

Hello @tabish121 I cannot see this change getting applied to the 1.x-flavors... am I looking in the wrong place or are they simply not affected by the leak in the first place?

tabish121 commented 2 years ago

The 1.x line is essentially end of life, folks should be moving onto 2.x as that is the currently active line. I released a v1.2.4 with this fix just now but I don't plan on doing more so I'd encourage you to move to 2.x

AntonRoskvist commented 2 years ago

Sounds good and I agree with you on leaving the old 1x-stuff. I'm just stuck with it through some old Spring dependencies for a little while longer, otherwise I'm using 2.x already. Thanks for getting back to me so fast!