messari / subgraphs

Standardized subgraphs for blockchain data
MIT License
512 stars 241 forks source link

Silo Finance Mainnet QA #1452

Open SerenityFund opened 2 years ago

SerenityFund commented 2 years ago

Review Info

Description Info
Subgraph Reviewed https://subgraphs.messari.io/subgraph?endpoint=https://gateway.thegraph.com/api/2b7eeacb471d383c093a79133a0a17a4/subgraphs/id/6rcT2GzBXGoi3ZMus92LHajM2b9qWGj7Z3dDhPxoUogB&tab=protocol
Schema Version 2.0.1
Subgraph Version 1.0.0
Methodology Version 1.0.0
Evidence Spreadsheet https://docs.google.com/spreadsheets/d/1IYNWOHhRV2MQZJ7vDPBcxdXcwQpPMjlJ/edit?usp=sharing&ouid=104027705798814439445&rtpof=true&sd=true

Metric to Review

TVL

Subgraph - Nov. 20 TVL Defi Llama - Nov. 20 TVL Absolute difference Difference %
3,037,784.97 18,104,868.40 -15,067,083.43 -83.22%
Subgraph - Nov. 15-19 average TVL Defi Llama - Nov. 15-19 average TVL Absolute difference Difference %
2,985,967.73 2,813,712.55 172,255.18 6.22%

Revenue

Total Pool Count

Pool Overview

Pool Vault

USDC pool

Please refer to the attached worksheet for more details.

Data-Nexus commented 2 years ago

TVL The protocol's ~3m accounts for all user deposits. The recent bump to ~18m was due to a XAI (protocol's stablecoin) credit extension that was minted and deposited into the markets. Initial consensus was excluding this in TVL (since it is minted by the protocol) but after inspecting what other protocol's are doing the team has decided to count this in the TVL.

This will be updated early this week on the mainnet subgraph version (see https://thegraph.com/hosted-service/subgraph/data-nexus/silo-data-nexus as the pre-prod subgraph).

Revenue The protocol has not started earning revenue, however there is supply side revenue that needs to be updated in the subgraph and accounted for. This is on my TODO list.

Total Pool Count There are subgraphs that have been deployed but do not yet have a PriceProvider (oracle for the assets in the market) established. Once the oracle is established the market will show on the front end of the website.

Pool Overview The 4 pools mentioned show in the new version. I'll inspect the TVL discrepancies between the markets.

Pool Vault Max LTV and Liquidation threshold differ slightly in the Silo structure. This has been broken into a 1:M relationship in our new version where we create a MarketAsset entity which stores the LTV and LT for each asset inside the market.