Open SerenityFund opened 1 year ago
@harsh9200 QA here. Feels like those protocol level volume and TVL metrics are probably from that pricing issue we discussed.
@harsh9200 @bye43 Will this be fixed when we apply the uniswap fork pricing fix to balancer forks?
cc @steegecs
I think if we derived the prices from the pool it would. However, it looks like currently the prices are coming from harsh's price lib. Can you confirm @harsh9200?
Yes, right now balancer forks deployments are using my price lib. My price lib does not handle some tokens artificially created by balancer (Example). To fix this I have deployed a price lib based on a new method which is deriving prices based on the swaps of a pool, but It has also some bugs that I am still fixing. I wonder if @steegecs price lib would work on these types of artificial tokens.
Review Info
Metric to Review
TVL
TVL data is not mathematically in line with the recent (Feb. 3) official website data as it shows a massive discrepancy of -50.51%. Additionally, in the five past five days, the TVL data shows discrepancies ranging from -46.20% to -57.78% with Defi Llama data,
February 3, 2023:
Revenue
The daily total revenue data is not aligned with the revenue data from the official website, showing a discrepancy of -28.17%.
February 3, 2023:
Daily Volume
The recent daily volume data shows a high discrepancy of -28.29% with official website data.
February 3, 2023:
Daily Transaction Count
Daily transaction count data is not mathematically in line with the sum of deposit, withdraw, and swap daily counts in the past five days.
Total Pool Count
Dexscreener, Defi Llama, and the official website only show 38, 92, and 9 pools respectively (compared to the subgraph's 142 pools).
Pool Overview - TVL and Rewards
Please refer to the attached worksheet for more details.