messari / subgraphs

Standardized subgraphs for blockchain data
MIT License
510 stars 240 forks source link

makerdao: Indexing Errors #1855

Closed this-username-is-taken closed 1 year ago

this-username-is-taken commented 1 year ago

ethereum: Block #16802255 - https://okgraph.xyz/?q=messari%2Fmakerdao-ethereum - Mapping aborted at src/common/helpers.ts, line 614, column 5, with message: [updatePosition]balance for position 0x66ae0574eb28b92c82569b293b856bb99f80f040-0xa13c0c8eb109f5a13c6c90fc26afb23beb3fb04a-BORROWER-0 -2528510946552692086451 < 0 wasm backtrace: 0: 0xa3c3 - !src/common/helpers/updatePosition 1: 0xde50 - !src/mapping/handleVatFrob in handler handleVatFrob at block #16802255 (a84508d010ee98a289946a29ea684d2a799de8b9ed6652d97c4d3634307998b6)

bye43 commented 1 year ago

@tnkrxyz Could you take a look at this when you get the chance? Thanks!

tnkrxyz commented 1 year ago

@tnkrxyz Could you take a look at this when you get the chance? Thanks!

Working on it.

OK, this is maker's new D3MHub breaking our subgraph. Coming up with a fix soon.

tnkrxyz commented 1 year ago

Fixed in #1858. I also started a deployment from scratch to make it my changes don't break something else.

BTW, feel free to assign makerdao tasks to me in the future.

bye43 commented 1 year ago

This looks good on the QA side. Will let @jaimehgb review the PR. Thanks @tnkrxyz

bye43 commented 1 year ago

@tnkrxyz Going to leave this open cause otherwise the bot opens new indexing issues but going to leave in syncing

bye43 commented 1 year ago

@jaimehgb can we deploy this to the messari-hosted - https://github.com/messari/subgraphs/pull/1858#issuecomment-1469046837