messari / subgraphs

Standardized subgraphs for blockchain data
MIT License
506 stars 239 forks source link

Mummy Finance - FANTOM #2143

Closed SerenityFund closed 1 year ago

SerenityFund commented 1 year ago

Review Info

Description Info
Subgraph Reviewed https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/id/Qma8rCUYJiAhJmMt3PG5Dsxqs5KNbpbr2ijaAQ83BpQ6BF&tab=protocol
Schema Version 1.3.0
Subgraph Version 1.0.0
Methodology Version 1.0.0
Evidence Spreadsheet https://docs.google.com/spreadsheets/d/1pMqi3pWSYhfFHkA8v6aSks6LXohuO36B/edit?usp=sharing&ouid=104027705798814439445&rtpof=true&sd=true

Metric to Review

Daily Protocol Side Revenue

5-day average (from May 12 to 16 of 2023)

Subgraph - Protocol Side Revenue Token Terminal - Protocol Side Revenue Absolute difference Difference %
939.53 3,750.99 -2,811.46 -74.95%

Daily Volume USD

5-day average (from May 12 to 16 of 2023)

Subgraph - Daily Volume USD Defi Llama - Daily Volume USD Absolute difference Difference %
70,550.24 2,766,000.00 -2,695,449.76 -97.45%
Subgraph - Daily Volume USD Dune Analytics - Daily Volume USD Absolute difference Difference %
70,550.24 4,588,766.22 -4,518,215.98 -98.46%

Daily Short and Total Open Interest

4-day average (from May 13 to 16 of 2023)

Subgraph - Daily Short Open Interest (day to day change) Official Website - Daily Short Open Interest Absolute difference Difference %
812,214.86 2,862,717.96 -2,050,503.09 -71.63%

4-day average (from May 13 to 16 of 2023)

Subgraph - Daily Total Open Interest (day to day change) Official Website - Daily Total Open Interest Absolute difference Difference %
1,317,586.17 3,387,160.83 -2,069,574.66 -61.10%

Daily Transaction Count

Reward Token Emissions data - MMY Vault

As of May 16, 2023

Subgraph - Implied MMY token price CoinGecko - MMY token price Difference %
1.77 3.57 -50.54%

Please refer to the attached worksheet for more details.

bye43 commented 1 year ago

@shashwatS22

ishraq8 commented 1 year ago

Took a look at the fixes from: https://github.com/messari/subgraphs/pull/2075

  1. token terminal combines revenue to stake holders and revenue to treasury as protocol side revenue. we seperate these to stake side and protocol side revenue. Numbers are accurate when you add them together.
  2. Volume looks accurate for fantom (some differences in day overlap) However it does look off compared to DefiLlama on optimism: Screen Shot 2023-05-25 at 11 25 22 AM.
  3. open interest looks good in both
  4. transaction count is slightly off can you double check?
  5. pricing issue looks resolved

@shashwatS22 great work, just fix # 2 and # 4

ishraq8 commented 1 year ago

volume matches dune, defillama was including internal protocol swaps. transaction count is accurate too.

this is ready to deploy.

melotik commented 1 year ago

@bye43 we should also check if gmx changed at all. I did a quick scan and some things are off by 1-5%... It is still syncing, but not sure if this is a raise for concern

ishraq8 commented 1 year ago

Will double check on gmx on this deployment

ishraq8 commented 1 year ago

I checked the avalanche deployment to stat.gmx.io they are within 1% similar for volume (which they call margin trading volume), open interest, total revenue and TVL to defillama

there is a discrepancy on how they label date (their labeling is one day behind ours). We can wait for arbitrum as that is behind the data on the official gmx site.