fishTsai20
commented
1 month ago Hi @fishTsai20, I've reviewed your PR, and overall, the changes look really good! Thanks for your work on this.
Just one thing: could you please take a look at and fix the linting issues in the CI/CD? It would ensure everything aligns perfectly with our coding standards. Also, can you send the deployment id of the subgraph?
subgraph ID : AxY4fTdsWG3Y48apG8T6WwKEwRKGrsr4WFBZWJp5HzYC
name: Feature request about: Support Curve new protocol title: "#feature; curve; handle TricryptoPoolDeployed event" labels: enhancement assignees: ishraq8
What do you think is missing? The Curve configuration was outdated and missing the factory address for the tricrypto pools as well as the function to handle the creation of pool contracts.
Describe the solution you'd like
add CurveTricryptoFactory address
add handle TricryptoPoolDeployed function
support new protocol
Description The Curve configuration was outdated and missing the factory address for the tricrypto pools as well as the function to handle the creation of pool contracts.
Additional context https://thegraph.com/explorer/subgraphs/AxY4fTdsWG3Y48apG8T6WwKEwRKGrsr4WFBZWJp5HzYC?view=Query&chain=arbitrum-one