search

messense / jieba-rs

The Jieba Chinese Word Segmentation Implemented in Rust
MIT License
738 stars 46 forks source link

add load default #81

Closed wyhhh closed 3 years ago

wyhhh commented 3 years ago

speed up 20%+

codecov[bot] commented 3 years ago

Codecov Report

Merging #81 (7df4626) into master (2da3243) will decrease coverage by 0.00%. The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   90.60%   90.59%   -0.01%     
==========================================
  Files           9       10       +1     
  Lines         947      968      +21     
==========================================
+ Hits          858      877      +19     
- Misses         89       91       +2
Impacted Files Coverage Δ
src/lib.rs 95.13% <88.88%> (-0.24%) :arrow_down:
src/load_default.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2da3243...7df4626. Read the comment docs.

messense commented 3 years ago

感觉不是很值得为 load_dict 这个一次性的损耗维护两套代码逻辑。

wyhhh commented 3 years ago

有些部分可以抽离出来，我只是没改而已

wyhhh commented 3 years ago

暂时先不管了