messense / mupdf-rs

Rust binding to mupdf
GNU Affero General Public License v3.0
104 stars 23 forks source link

Add address sanitizer CI job & fix #27 #34

Closed Bobo1239 closed 3 years ago

Bobo1239 commented 3 years ago

The first commit adds a Address Sanitizer job to our CI. See https://github.com/Bobo1239/mupdf-rs/runs/3329570361?check_suite_focus=true#step:4:230 for how the address sanitizer detected #27. The second commit fixes the bug by tracking the necessary lifetimes and making the code from the issue uncompilable without modifications.

messense commented 3 years ago

The windows build is wacky since we switched to mupdf master branch.