messhof / Input-Dog

This is a collection of scripts for Game Maker: Studio that manage joysticks, gamepads, and custom mappings. It also includes replay support.
https://marketplace.yoyogames.com/assets/243/input-dog
MIT License
42 stars 7 forks source link

inputdog_get_gamepad_string bumpers and triggers switched? #3

Open bmmund opened 5 years ago

bmmund commented 5 years ago

When using the inputdog_get_gamepad_string definitions, gp_shoulderrb maps to r_trig. I had thought it should map to r_bump instead as the "b" suggests its a bumper.

https://github.com/messhof/Input-Dog/blob/1997d0713503ebe4f6677153e3dcc1afe758b159/InputDog.gmx/scripts/inputdog_get_gamepad_string.gml#L17-L20

    case gp_shoulderl: return "l_bump"; break;
    case gp_shoulderlb: return "l_trig"; break;
    case gp_shoulderr: return "r_bump"; break;
    case gp_shoulderrb: return "r_trig"; break;
AceKiron commented 3 years ago

I'm actually surprised nobody has answered this yet.

Anyway, I don't know why YoYoGames chose to do it this way, but as stated on the documentation regarding these constants gp_shoulderrb is the right trigger, while gp_shoulderr is the right bump. image