mesyeux / pe

0 stars 0 forks source link

Inconsistent diagram sizes #13

Open mesyeux opened 3 years ago

mesyeux commented 3 years ago

Screenshot 2021-04-16 152717.png Screenshot 2021-04-16 152755.png

Diagram sizes that are too big could hinder the reader by causing the need for excessive scrolling.

nus-pe-bot commented 3 years ago

Team's Response

Severity downgraded from low to very low as it is purely a cosmetic issue.

Reasons for rejection:

1) It is reasonable that diagrams with more information will be bigger and take up more space. We cannot possibly resize all diagrams to the same size because they contain different amount of information.

2) If diagrams that have a lot of information are resized to be smaller, some text would be too small to read and that will hinder the readers more so than the scrolling.

3) All diagrams will have a minimum height, therefore smaller diagrams will be enlarged. However, these small diagrams after resizing will take up at most 1/4 of a page in the PDF, therefore the scrolling required should not be excessive.

4) The diagrams are there for readers to read and understand them, not to just scroll past. With our largest diagram only taking up 2/3 of a page in the PDF, the scrolling required should not be excessive.

5) If readers want to view a specific component in the DG, we have provided a table of content at the start of our DG for readers to easily navigate to each component.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]