search

met / subfilter

🎥+📚 Watch your favourite series on Netflix and improve foreign language at the same time. Chrome+Firefox extension to practice your listening skills. Support over 20 languages available on Netflix.🌍
https://github.com/met/subfilter/wiki
MIT License
18 stars 2 forks source link

Allow skipping to prev/next subtitle. #34

Open cessen opened 3 years ago

cessen commented 3 years ago

Moved over to this from the (seemingly unmaintained) subadub, and was very pleasantly surprised to see the b hotkey for repeating the last subtitle.

Would it be possible to also add keys for navigating to the prev/next subtitle? I sometimes find that functionality useful while studying.

I'd also be happy to take a crack at implementing this myself, if you can point me in the right direction.

met commented 3 years ago

@cessen Hi, thank you for your interest.

I think jumping to the next subtitle would be a good option.

Probably for the n hotkey. It looks that it is not used as shortcut by Netlix itself and it is just next to b on English keyboard layout.

If you are patient, I can do in for the next release (someday this Autumn I guess).

If you want to try it by yourself, look here where hotkeys are registered: https://github.com/met/subfilter/blob/0046a571634fc556c82b5b33953e865e6e173548/dist/subfilter-ui.js#L3

Here is way how to seek to time with the next subtitle, that I use in mode Dialogs only: https://github.com/met/subfilter/blob/0046a571634fc556c82b5b33953e865e6e173548/dist/subfilter-ui.js#L164