There is an issue with all rules defined as "greater than", but for one specific requirement, the rule requires "minor than".
@marioney can you provide detail? Feel free to edit the issue.
EDITED:
The new version of the tomasys ontology unifies the rules to check NFRs, it uses a single rule that checks if the observed value is larger than the requested value.
Since we have previously defined safety to have larger values mean safer configuration, it causes an error, ( i.e. safety = 1.0 will produce an NFR error.) We need to define safety as the inverse of what we had now. Also all future Quality Attributes should be defined so as to have larger values meaning worst QA.
This means that we need to change the definition of the safety observer to be 1-current_value
Also, the check to see if a given fd meets the NFR in the reasoner in tomasys.py should be checked, and perhaps generalized.?
Finally, the expected values for safety, also need to be changed, I think they are generated in by a this script but maybe @ipa-nhg can clarify this
There is an issue with all rules defined as "greater than", but for one specific requirement, the rule requires "minor than".
@marioney can you provide detail? Feel free to edit the issue.
EDITED:
The new version of the tomasys ontology unifies the rules to check NFRs, it uses a single rule that checks if the observed value is larger than the requested value.
Since we have previously defined
safetyto have larger values mean safer configuration, it causes an error, ( i.e.safety = 1.0will produce an NFR error.) We need to define safety as the inverse of what we had now. Also all future Quality Attributes should be defined so as to have larger values meaning worst QA.This means that we need to change the definition of the safety observer to be
1-current_valueAlso, the check to see if a given
fdmeets the NFR in the reasoner in tomasys.py should be checked, and perhaps generalized.?Finally, the expected values for safety, also need to be changed, I think they are generated in by a this script but maybe @ipa-nhg can clarify this