All function designs in error are added to fd_error_log

[Rezenders]

Every time a function grounding violates a NFR the objective it is solving is added to the function design fd_error_log. This shouldn't be the case for all violations, in the smart home for example we don't add the FDs to an error log. In addition, it doesn't make sense to block an FD for a violating a non-functional requirement.

Another issue I see is that the relationship order seems to be inverted. I would say that an FD is added to the objective error log and not the opposite.

But anyway, regarding the main issue I suggest:

• Making a distinction between non-functional requirements and functional requirements
• Only when a functional requirement is violated, the function design should be blocked

A quick solution for this in MROS could be to

• [x] meta-control/mc_mros_reasoner#143
• [x] meta-control/mc_mros_reasoner#144
• [x] Add IN_ERROR_FR to o_status

[Rezenders]

Done

[Rezenders]

@chcorbato FYI

[chcorbato]

We need to keep track of this change in the tomasys metamodel, i.e. values for 'Objective.status' Have you edited tomasys.owl in some branch @Rezenders ? Maybe good to indicate it here.

[Rezenders]

I only modified mros.owl and its SWRL rules. Changes are in the main branch. https://github.com/meta-control/mros_ontology/commit/dd139f07854b52f3298d23c0a1232cce28cd538a I didn't change the o_status. I will add that to tomasys.

[Rezenders]

Done at https://github.com/meta-control/mc_mdl_tomasys/commit/a020191e7e7c52d4f5aa3e2240fca2ea269bf940