search

meta-llama / llama-models

Utilities intended for use with Llama models.
Other
4.88k stars 838 forks source link

Rename models -> llama_models #197

Closed ashwinb closed 3 weeks ago

ashwinb commented 3 weeks ago

This idiosyncrasy causes a lot of unnecessary annoyances down the line. It is a pretty standard practice to have the package name be the exact sub-directory within the repository.

github-actions[bot] commented 3 weeks ago
30 passed
ashwinb commented 3 weeks ago

@raghotham where are these model card URLs referenced btw? from the README or directly outside too?

if I restore those with appropriate symlinks, would that be OK?

ashwinb commented 3 weeks ago

Added a symlink for models -> llama_models so no URL is invalidated.

ashwinb commented 3 weeks ago

https://github.com/meta-llama/llama-models/pull/201 is better I think as an option.