search

meta-llama / llama-models

Utilities intended for use with Llama models.
Other
4.88k stars 838 forks source link

Possible small issue with descriptor method of Model class in datatypes.py #209

Closed Maiguek closed 1 week ago

Maiguek commented 2 weeks ago

I was having problems downloading the Llama3.2 quantized instruct models, as the combo of model_id + variant was defined as a string of f"{self.core_model_id.value}:{self.variant}", in line 197 of datatypes.py.

The ":" was causing a system error while trying to create a folder with this name on Windows, and modifying it by a "-" like this -> f"{self.core_model_id.value}-{self.variant}" solved my problem 🍡

varunfb commented 1 week ago

Thank you for reporting the issue. @ashwinb this is something we have to fix based on the machine these commands are run?

ashwinb commented 1 week ago

Fixed this with https://github.com/meta-llama/llama-stack/commit/285cd26fb242a7e5d87ec66bea437f3a62e0eeea

The next version of the llama-stack package will have this fixed.