meta-llama / llama-recipes

Scripts for fine-tuning Meta Llama with composable FSDP & PEFT methods to cover single/multi-node GPUs. Supports default & custom datasets for applications such as summarization and Q&A. Supporting a number of candid inference solutions such as HF TGI, VLLM for local or cloud deployment. Demo apps to showcase Meta Llama for WhatsApp & Messenger.
15.29k stars 2.21k forks source link

fix typo in auto wrap policy #793

Closed hiaoxui closed 2 days ago

hiaoxui commented 3 days ago

I think this might be a typo; there is no reason to write MllamaSelfAttnDecoderLayer twice. Let me know if it was intentional.

What does this PR do?

This fixes a typo as mentioned above.

Feature/Issue validation/testing

I tested with my local training script.

This is a minor change; I didn't write new tests.

Before submitting

Thanks for contributing 🎉!

facebook-github-bot commented 3 days ago

Hi @hiaoxui!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

wukaixingxp commented 2 days ago

Hi! Thank you so much for this bug report. It is indeed a typo that should be fixed ASAP.

wukaixingxp commented 2 days ago

@hiaoxui Can you sign the CLA check so I can get this merged ASAP? Thanks!

wukaixingxp commented 2 days ago

@hiaoxui Thanks for your help! It will be merged now