Switch to new style override syntax

meta-rust / cargo-bitbake

cargo extension that can generate BitBake recipes utilizing the classes from meta-rust

Apache License 2.0

83 stars 57 forks source link

Switch to new style override syntax #37

Closed avrabe closed 2 years ago

avrabe commented 3 years ago

Otherwise building in honister is not working anymore. Seems to me it is now enforced to use the new syntax.

hberntsen commented 2 years ago

Note that older releases, e.g. dunfell, are supported by the Yocto project for at least until April 2022: https://wiki.yoctoproject.org/wiki/Releases . So we maybe need a flag to toggle the new syntax behaviour?

avrabe commented 2 years ago

The current meta-rust already changed to the new syntax and therefore depends on a version greater than dunfell-23.0.10. The switch would then mainly apply for all code bases relying on older meta-rust commits being used. Is this something which needs to be supported?

srwalter commented 2 years ago

I don't see a need for a toggle for the new syntax. dunfell does support the new syntax, and I can't think of a good reason why someone wouldn't be able to use the newest dunfell release

hellow554 commented 2 years ago

I propose that this should be merged. As @avrabe pointed out, meta-rust already implemented the override syntax in https://github.com/meta-rust/meta-rust/commit/bf6705fb7f41b16c3277cbf84af0b9757dcd3a01

Dunfell is supported, but anything earlier than that (zeus, ...) not.