Consider using a git submodule for the liblinear and slda dependencies.

meta-toolkit / meta

A Modern C++ Data Sciences Toolkit

https://meta-toolkit.org

MIT License

693 stars 235 forks source link

Consider using a git submodule for the liblinear and slda dependencies. #10

Closed smassung closed 10 years ago

smassung commented 10 years ago

removed slda

skystrife commented 10 years ago

(what about liblinear?)

smassung commented 10 years ago

Do we still want to have a liblinear wrapper? Yes

allow easier comparisons between our classifiers and liblinear
kernels?

forward_index postings file is compatible with liblinear, so it's trivial to run something we index with it

I guess it would be nicer to create the submodule... what do you think?

skystrife commented 10 years ago

Not sure I have a preference either way, since it's trivial now to use liblinear with our forward_index refactoring... but it lets you leverage the rest of the system. Maybe it's worth keeping?

Speaking of which, did we rewrite that part or are we still regenerating the input file despite the forward_index already being in that format?

smassung commented 10 years ago

That part needs to be rewritten if we're keeping it. Probably might as well, since it's even simpler now I think

smassung commented 10 years ago

Updated in c3eb82bd7999de04fc0b6bde69aab2429f81b665