search

meta00 / vital_sqi

A package for physiological signal quality control
MIT License
31 stars 11 forks source link

Error with pandas. pandas.DataFrame.append was deprecated #100

Closed tiagofrepereira2012 closed 1 year ago

tiagofrepereira2012 commented 1 year ago

Hi, the following tests are falling

FAILED tests/pipeline/test_pipeline_highlevel.py::TestGetPPGSQIs::test_on_get_ppg_sqis - AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?
FAILED tests/pipeline/test_pipeline_highlevel.py::TestGetQualifiedPPG::test_on_get_qualified_ppg - AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?
FAILED tests/pipeline/test_pipeline_highlevel.py::TestGetECGSQIs::test_on_get_ecg_sqis - AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?
FAILED tests/pipeline/test_pipeline_highlevel.py::TestGetQualifiedSQIs::test_on_get_qualified_ecg - AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?

The thing is that pandas.DataFrame.append used here https://github.com/meta00/vital_sqi/blob/main/vital_sqi/pipeline/pipeline_functions.py#L476, was deprecated a long time ago. Check here https://github.com/pandas-dev/pandas/issues/35407 and here https://github.com/pandas-dev/pandas/pull/44539

pandas.DataFrame.concat should be used instead.

I will push a fix shortly