search

meta00 / vital_sqi

A package for physiological signal quality control
MIT License
32 stars 11 forks source link

Unit testing #35

Closed meta00 closed 3 years ago

meta00 commented 3 years ago

add unit tests and recode signal_io.py

meta00 commented 3 years ago

add an assertion for sampling_rate with type float in signal_io.

Ok to merge, thanks.

done in commit 6c860bd7a60edc0b1f3695dbcc538c247c7b8130

codecov[bot] commented 3 years ago

Codecov Report

Merging #35 (6c860bd) into main (82792cf) will increase coverage by 8.67%. The diff coverage is 80.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   19.92%   28.59%   +8.67%     
==========================================
  Files          23       23              
  Lines        1581     1640      +59     
==========================================
+ Hits          315      469     +154     
+ Misses       1266     1171      -95
Impacted Files Coverage Δ
vital_sqi/data/signal_io.py 87.07% <79.22%> (+77.50%) :arrow_up:
vital_sqi/common/utils.py 80.64% <85.00%> (+38.42%) :arrow_up:
vital_sqi/sqi/rpeaks_sqi.py 0.00% <0.00%> (ø)
vital_sqi/data/signal_sqi_class.py 56.52% <0.00%> (+26.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82792cf...6c860bd. Read the comment docs.