meta4d-me / CatDogEngine

A cross-platform game engine/editor written in modern C++ (WIP)
GNU General Public License v2.0
159 stars 17 forks source link

fix inspector rotation use XYZ rotate #482

Closed VTui22 closed 8 months ago

T-rvw commented 8 months ago

What you need to improve is to learn to stand in different positions to review your codes so that you can make your codes more generic.

  1. If I am in Engine project, is it suitable to use variable name such as InspectorRotation? Is there a more generic name?
  2. If I am other developers who firstly see your comments, is it useful for others to learn something?
  3. If I am editor developer who wants to use API such as ImGuiTransformProperty, is the interface easy to understand?