metaDAOproject / meta-dao-frontend

https://app.themetadao.org
Other
16 stars 16 forks source link

start using futarchy-ts instead of lib #33

Open decartesol opened 4 months ago

decartesol commented 4 months ago

By switching lib to futarchy-ts (a separate repo) we get the following:

Thorns to be aware of:

R-K-H commented 4 months ago

Love this, I'll have some more time to review this in the coming week. Is there any reason to not just have NPM install (and deploy to npmjs) and be pushing the needed stuff into the -ts repo instead of needing to deal with submodules?

decartesol commented 4 months ago

Is there any reason to not just have NPM install (and deploy to npmjs) and be pushing the needed stuff into the -ts repo instead of needing to deal with submodules

The main issue I see here is w/ local development. If I need to change the lib code and the frontend code as part of the same change, submodules has a clear local dev story for this, whereas if we're not using submodules we need to come up with some alternative standard (like perhaps cloning the -ts repo beside the FE repo, npm-linking to the -ts repo then before pushing, changing it back to the npm version). It's doable, but seems like submodules is simpler. If submodules is unpopular we can come up w/ something else like what I mentioned.

R-K-H commented 4 months ago

Nah, just looking for clarification. Both are what I would consider unstable, so I'm not worried about how best to move it forward. I use and have used submodules for many things, so it is perfectly acceptable and sufficient IMO.

Edit: The only other thing I can think of is we can reference the github and commit / tag directly in the package.json as well, which can work locally.

The second thought I had was that building from/for github pages if it works? The ability to migrate to a Vercel or other provider instance is probably called for in the near term, so likely won't matter for long.

decartesol commented 4 months ago

building from/for github pages if it works?

It should work after the

with:
  submodules: 'true'

change I added to the checkout github workflows.

can reference the github and commit / tag directly in the package.json as well

does that work locally? I thought it would no longer use the local git submodule in that case. I'll check