When hiding columns on source question you can't remove click behavior

[paoliniluis]

Describe the bug When configuring click behaviour in columns, hiding any of those columns in click behavior does not let the user remove the click behaviour.

Logs There aren't any relevant logs, no backend or frontend

To Reproduce 1) Build a dashboard and add a table visualization 2) add click behaviour to that table on any column, save the dashboard 3) go to the question and hide a column from the table visualization settings 4) return to the dashboard and check the click behaviour setting, you won't see the column anymore, although the card will say that there is 1 column with click behaviour

Expected behavior Either we restrict the user from removing from the question the column that is used on the dashboard for the click behaviour, or we remove the click behaviour on the column on the dashboard when the column is removed from the viz settings of the question

Screenshots (sorry, I know a GIF might be hard to read, but sending a video rather than pictures you can go over and over)

Information about your Metabase Installation:

• Your browser and the version: Brave latest
• Your operating system: Ubuntu 20.04 LTS
• Your databases: Sample dataset
• Metabase version: .40.5
• Metabase hosting environment: Docker
• Metabase internal database: H2

Severity Cosmetic, at least

Additional context N/A

[kamilmielnik]

Expected result TBD, see Slack: https://metaboat.slack.com/archives/C057T1QTB3L/p1691588517142039?thread_ts=1691585903.901969&cid=C057T1QTB3L

[WiNloSt]

From @luizarakaki from Slack . I considered this the expected resulted from that discussion.

For #3, we are planning to separate add/remove from hide column. https://www.notion.so/metabase/Enable-Add-all-Remove-all-behavior-in-table-settings-f0b1fec023334b20a9c84b7c5304508f

So, for this bug, I think that if the column isn’t present in the query anymore, we should automatically remove the click behavior (if the column was removed from the select).

If the column was hidden in the visualization, but still exists in the query, we should keep it (in case someone unhides the column). I also think we will let the user unhide columns from the dashboard

[WiNloSt]

We decided to pause this fix until https://github.com/metabase/metabase/pull/32698 is merged, so we could use MLv2 functions instead.

Decision from Slack

[WiNloSt]

This will likely be fixed by [MLv2] Click mapping target selection in dashboards

See discussion