search

metabase / metabase

The simplest, fastest way to get business intelligence and analytics to everyone in your company :yum:
https://metabase.com
Other
37.47k stars 4.97k forks source link

Visualization does not recover from an error in native query editor #33327

Closed kamilmielnik closed 1 week ago

kamilmielnik commented 11 months ago

Describe the bug

Once native query can't be visualized, user can't recover from the error without leaving the page.

Video taken using 0.47.6:

https://github.com/user-attachments/assets/2dbc5918-d015-4705-9471-bb1a0c936027

To Reproduce

  1. Create new SQL query using sample db
  2. set the visualization and check "detail"
  3. Set the query to select 1; and run it - you'll get a number visualization
  4. Change the query to select --1; and run it - you'll get a visualization error
  5. Change the query back to select 1; and run it Visualization error is still shown

Expected behavior

Number visualization is shown

Information about your Metabase installation

f0dd90e64b, v47

Severity

P3

likeshumidity commented 11 months ago

Related to https://github.com/metabase/metabase/issues/32609 (improper parsing of --)

oleggromov commented 6 months ago

I could repro on 926b04a1d5377798b0bbb98ef6b28ddac3210c89