Fixing a couple Recents API corner cases

metabase / metabase

The simplest, fastest way to get business intelligence and analytics to everyone in your company :yum:

https://metabase.com

Other

37.09k stars 4.92k forks source link

Fixing a couple Recents API corner cases #42813

Closed escherize closed 3 weeks ago

escherize commented 4 weeks ago

We can't really rely on some app db constraints, so I am filtering out invalid recent view items for entities that are e.g. missing parent collections.

[x] remove an extra def that snuck itself into the tests
[x] uncomment + fix 2 tests
[x] ensure the parent collection for a card/model/dashaboard exists
[x] official is a string
[x] ensure the database for a recent table exists

replay-io[bot] commented 4 weeks ago

Status	Complete ↗︎
Commit	bb647595809ed3e6a5ecc9609f3b13dd1a330cea
Results	⚠️ 3 Flaky ✅ 2567 Passed

github-actions[bot] commented 3 weeks ago

@escherize Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?