metabase / metabase

The simplest, fastest way to get business intelligence and analytics to everyone in your company :yum:
https://metabase.com
Other
36.96k stars 4.9k forks source link

Prevent chrome crash in cypress when input has auto-focus #42818

Open uladzimirdev opened 2 weeks ago

uladzimirdev commented 2 weeks ago

[!IMPORTANT] For those employed by Metabase: if you are merging into master, please add either a backport or a no-backport label to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this PR? in the Metabase Branching Strategy document for more details. If you're not employed by Metabase, this section does not apply to you, and the label will be taken care of by your reviewer.

Warning

If that is your first contribution to Metabase, please sign the Contributor License Agreement (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our POEditor project instead of opening a PR.

Closes https://github.com/metabase/metabase/issues/[issue_number]

Description

Describe the overall approach and the problem being solved.

How to verify

Describe the steps to verify that the changes are working as expected.

  1. New question -> Sample Dataset -> ...
  2. ...

Demo

Upload a demo video or before/after screenshots if sensible or remove the section

Checklist

github-actions[bot] commented 2 weeks ago

Codenotify: Notifying subscribers in CODENOTIFY files for diff fca30b1ae5ef75bbaead824f27c27a3f1694c67c...79adc8295e7ba884d4317745ca0bce36014d117f.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/visualizations/Heading/Heading.tsx
frontend/src/metabase/visualizations/visualizations/Heading/Heading.unit.spec.tsx
frontend/src/metabase/visualizations/visualizations/Text/Text.jsx
frontend/src/metabase/visualizations/visualizations/Text/Text.unit.spec.tsx
replay-io[bot] commented 2 weeks ago

Status Complete ↗︎
Commit 79adc8295e7ba884d4317745ca0bce36014d117f
Results
⚠️ 1 Flaky
2568 Passed