metabase / metabase

The simplest, fastest way to get business intelligence and analytics to everyone in your company :yum:
https://metabase.com
Other
37.43k stars 4.97k forks source link

Dashboard Filters Saving over defaults from last opened version of dashboard #44438

Open AR123AFF opened 1 month ago

AR123AFF commented 1 month ago

Describe the bug

When i open a link to a dashboard with a filter that is not the dashboard default filter, Then if i close the browser (with non default browsers selected) and reopen the same dashboard from the folder link which previously opened only with default filters, The last saved filters override the default filters. This also happens cross dashboard for duplicated dashboards with different filters defaulted (with intention)

To Reproduce

  1. Go to '...'one dashboard with default filters
  2. Click on '....'a random extra filter
  3. Scroll down to '....; a new browser with the same original dashboard
  4. See error filters in step two applied to step 3 without manually doing this and overriding default filters

Expected behavior

If you manually add filters to a dashboard that has different default filters, close a browser and open the base dashboard, only the default filters will open when you reopen the base dashboard. Similarly if you create duplicated dashboards with different defualt filters opening and closing one dashboard would not auto apply the the original default filters into a different dashboard.

Logs

i dont know how to do this. this behavior was reproduced by multiple colleagues, so i know im not special - please contact averill.roberto@affecttherapeutics.com (me) or David.Svensen@affecttherapeutics.com (our metabase expert)

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.23+9",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "11.0.23",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.23+9",
    "os.name": "Linux",
    "os.version": "5.4.0-1125-aws",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "postgres",
      "redshift"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "13.8 (Debian 13.8-1.pgdg90+1)"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.7.3"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2024-06-19",
      "tag": "v0.50.6",
      "hash": "a5fbebf"
    },
    "settings": {
      "report-timezone": "America/Los_Angeles"
    }
  }
}

Message David Svensen

Severity

Blocking billing error correction and therefore affecting AR (financials)

Additional context

Cant send screen shots because it has PHI

paoliniluis commented 1 month ago

Can you give us more information? the dashboard still has the default filters, but in v50 we decided to also keep what the users select and we save that in the browser

AR123AFF commented 1 month ago

Is there a way that we can NOT cache the most recent filters and only use default filters and empty filters upon dashboard loading? We use complicated filtering for different audiences in a workflow and even different providers due to separate email setup of reports based on coverage.

Averill

On Wed, Jun 19, 2024 at 3:49 PM Luis Paolini @.***> wrote:

Can you give us more information? the dashboard still has the default filters, but in v50 we decided to also keep what the users select and we save that in the browser

— Reply to this email directly, view it on GitHub https://github.com/metabase/metabase/issues/44438#issuecomment-2179377069, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJKGQTZZUNUEXXJE3KDFCYDZIHOE7AVCNFSM6AAAAABJSTXQEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGM3TOMBWHE . You are receiving this because you authored the thread.Message ID: @.***>

uladzimirdev commented 1 month ago

@AR123AFF the last used filter values are saved per user, so another user will have everything blank. if you use different values often, maybe it's a point to update default values?

could you please explain why do you want default values to be kept instead of last used?

uladzimirdev commented 1 month ago

related issue https://github.com/metabase/metabase/issues/43001, covers "duplicate dashboard" part

AR123AFF commented 1 month ago

Hello,

We have many dashboards that identify billing "Errors" detected by the system. Different default filters on duplicated dashboards are intended for different audiences. For example, one set of filters may be for health care providers completing documentation defaulted if that person provides coverage for a particular state. We then have the providers specific dashboard sent to them regularly. Another version of that dashboard may be default to a different provider or a different state. Similarly the type of visit may be relevant for medical staff and a different type of visit filter for the therapists.

By having different default filters as an administrator, i can look how provider X is doing with their personnel completion of work and maintain only one base report. This creates a lot of complication for supervisors and for administrators when default filters are overridden by last filtered.

Can we turn off the feature?

Averill

On Thu, Jun 20, 2024 at 6:43 AM Uladzimir Havenchyk < @.***> wrote:

related issue #43001 https://github.com/metabase/metabase/issues/43001

— Reply to this email directly, view it on GitHub https://github.com/metabase/metabase/issues/44438#issuecomment-2180368759, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJKGQT7WXQGCZFSI2QCRONTZIKW6HAVCNFSM6AAAAABJSTXQEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGM3DQNZVHE . You are receiving this because you were mentioned.Message ID: @.***>

paoliniluis commented 1 month ago

We should have a reset button to clean the filters to the "default" state (asked by one of our customers)

AR123AFF commented 1 month ago

Thank you, when will this button be available? FWIW this is not ideal for us given the rapid nature of our work and the extra clicking.

Best, Averill

Message ID: @.***>

uladzimirdev commented 1 month ago

@AR123AFF it already exists, but you'll see it only when "always require a value" is selected

Screenshot 2024-06-20 at 22 43 40

https://github.com/metabase/metabase/assets/125459446/50b08f9e-2a14-4ea6-b077-09345b9e1b98