metabase / saml20-clj

A Clojure SAML 2.0 library for SSO
35 stars 12 forks source link

Stop assuming SAML XML namespace is saml: #46

Closed camsaul closed 1 year ago

camsaul commented 3 years ago

There are a few places where we assume the SAML namespace is called saml:. For example, we look for an element specifically matching saml:EncryptedAssertion.

It seems like in practice this is almost always true, but we have ran into at least one situation where the namespace was saml2: -- see #45.

We should either figure out the correct namespace from the relevant xmlns: attribute or not look for the namespace part at all (I doubt there would be any non-SAML EncryptedAssertion elements in the response)

camsaul commented 1 year ago

Fixed in #60