metabase / toucan

A classy high-level Clojure library for defining application models and retrieving them from a DB
Eclipse Public License 1.0
569 stars 49 forks source link

Allow dashed names #26

Closed AndreTheHunter closed 6 years ago

AndreTheHunter commented 6 years ago

Thanks for contributing to Toucan. Before open a pull request, please take a moment to:

Once you've done all that, open a PR! Make sure to at-mention @camsaul in the PR description. Otherwise I won't get an email about it and might not get review it right away. :)

Thanks for your contribution!

camsaul commented 6 years ago

@AndreTheHunter this looks good, but it would be great to document this somewhere. I think a new section after this one https://github.com/metabase/toucan/blob/master/docs/setup.md#configuring-quoting-style is the best place to put it

camsaul commented 6 years ago

I'll go ahead and merge this and clean up the last couple things.

camsaul commented 6 years ago

Upon some reflection I ended up renaming this to from allow-dashed-names to automatically-convert-dashes-and-underscores (and defaulting to false) since the latter name much more clearly explains what exactly it does. See PR #29