Closed AndreTheHunter closed 6 years ago
@AndreTheHunter this looks good, but it would be great to document this somewhere. I think a new section after this one https://github.com/metabase/toucan/blob/master/docs/setup.md#configuring-quoting-style is the best place to put it
I'll go ahead and merge this and clean up the last couple things.
Upon some reflection I ended up renaming this to from allow-dashed-names
to automatically-convert-dashes-and-underscores
(and defaulting to false) since the latter name much more clearly explains what exactly it does. See PR #29
Thanks for contributing to Toucan. Before open a pull request, please take a moment to:
[x] Tests and linters pass. You can run them locally as follows:
lein test && lein lint
(CircleCI will also run these same tests against your PR.)
[x] Carefully review your own changes and revert any superfluous ones. (A good example would be moving words in the Markdown documentation to different lines in a way that wouldn't change how the rendered page itself would appear. These sorts of changes make a PR bigger than it needs to be, and, thus, harder to review.)
Of course, indentation and typo fixes are not covered by this rule and are always appreciated.
Once you've done all that, open a PR! Make sure to at-mention @camsaul in the PR description. Otherwise I won't get an email about it and might not get review it right away. :)
Thanks for your contribution!