metabase / toucan

A classy high-level Clojure library for defining application models and retrieving them from a DB
Eclipse Public License 1.0
569 stars 49 forks source link

Add support for reducible java.jdbc calls #30

Closed senior closed 6 years ago

senior commented 6 years ago

Opening this PR as what I think is probably the most straightforward way to incorporate the reducible support that java.jdbc has added. Not sure if this is the best way, but it seemed like the easiest. Submitting this as an RFC of sorts. If this approach seems like the right way to go about it, I'll get the tests and docs written up to accompany it.


Thanks for contributing to Toucan. Before open a pull request, please take a moment to:

Once you've done all that, open a PR! Make sure to at-mention @camsaul in the PR description. Otherwise I won't get an email about it and might not get review it right away. :)

Thanks for your contribution!

camsaul commented 6 years ago

In principle this looks good but we should add some tests & dox. Then we can merge

senior commented 6 years ago

@camsaul done