Closed axrs closed 5 years ago
Can you please carefully go thru your PR and remove all the changes to the CI config and other unrelated changes. It looks to me like you might just need to rebase your commit off latest
master
.
The changes in the CircleCI yaml config allows allows us to deploy our own fork. See https://circleci.com/gh/jesims/workflows/toucan deploying to https://clojars.org/io.jesi/toucan. I've made that configuration environment variable driven as not break anything in metabase/toucan. Since we need our changes in production, we can't always wait for it to be merged into the upstream.
I've checked, and this branch is up to date with master. I'd recommend configuring this repository and setting master as a protected branch. Go to https://github.com/metabase/toucan/settings/branches. See https://help.github.com/articles/enabling-required-status-checks/ for more info.
Happy to discuss any changes/alternatives 😃
I don't want to merge those changes you've made to the CI config or project.clj
into the core Toucan repo
@camsaul Those changes wouldn't break anything but OK.
I've added some comments outlining the changes to project.clj
Thanks @AndreTheHunter. Looks good.
Merged. I'll update documentation and other things in a few days and push out a new release if all looks good
Pushed out release 1.11.0 which includes this PR. Thanks again
Added in support for changing the primary key, https://github.com/metabase/toucan/issues/3
Thanks for contributing to Toucan. Before open a pull request, please take a moment to:
[x] Tests and linters pass. You can run them locally as follows:
lein test && lein lint
CircleCI will also run these same tests against your PR. See the README for more details on running tests.
[x] Carefully review your own changes and revert any superfluous ones. (A good example would be moving words in the Markdown documentation to different lines in a way that wouldn't change how the rendered page itself would appear. These sorts of changes make a PR bigger than it needs to be, and, thus, harder to review.)
Of course, indentation and typo fixes are not covered by this rule and are always appreciated.
Once you've done all that, open a PR! Make sure to at-mention @camsaul in the PR description. Otherwise I won't get an email about it and might not get review it right away. :)
Thanks for your contribution!