search

metabase / toucan

A classy high-level Clojure library for defining application models and retrieving them from a DB
Eclipse Public License 1.0
570 stars 49 forks source link

Any Plans or Interest in Moving to HoneySQL 2? #92

Open cmiles74 opened 2 years ago

cmiles74 commented 2 years ago

Hi @camsaul!

I'm working on a project that uses Toucan and HoneySQL 2.x. I've run into a couple bugs where people try to feed a structured HoneySQL 2 query into Toucan. It's not a huge deal, but...

I was wondering: are there any plans (or even interest) in moving to HoneySQL 2?

skyfion commented 1 year ago

It's a good idea, Is it enough to override honeysql->sql function for this ?

cmiles74 commented 1 year ago

It might be as easy as swapping the functions. I was looking around a little to try and gauge how difficult it would be... The new version does try to stay compatible with the old.

Mostly I was wondering if this project is interested in moving or if they want to stay with the current version.

skyfion commented 1 year ago

Mostly I was wondering if this project is interested in moving or if they want to stay with the current version.

it looks like not 🙂 But migrations from hsql 1 to 2 become a bit more complicated

flamber commented 1 year ago

Have a look here https://github.com/camsaul/toucan2#toucan2-toucan1

vldmr-k commented 1 year ago

Better choice https://github.com/HealthSamurai/dsql It is flexible and extendable lib