Mysterious popover UI menu makes me worry about leakage between alts

[alexbbrown]

Describe the bug when long pressing on a favorite icon (or boost), it shows the name of one of my accounts-but not the one I am currently logged in as

by analogy with the slack like system, I interpret that as meaning thats's who liked it. But that's not "me" right now, that's my alt.

To Reproduce Steps to reproduce the behavior:

1. Have two accounts signed in in app
2. Have first account selected (checked in app list)
3. Go to feed
4. Find a toot 🐘
5. Tap favorite star ⭐️
6. Tap hold favorite
7. observe the account name displayed is not the selected account, but the other

Expected behavior A clear and concise description of what you expected to happen.

when I favorite a toot, I expect that favorite to be recorded for my currently signed in account Actual: it displays an alt, as if it was recorded for the alt

is this publicly visible, or just a ui issue?

Screenshots If applicable, add screenshots to help explain your problem.

(please complete the following information):

• Device:. iPhone 12
• OS: 16.1.1
• App Version: 1.6

Additional context Add any other context about the problem here.

[alexbbrown]

It's possible I have misunderstood the intent of this popover UI. Perhaps it's not telling me "who favorited it" but something else. Is it a single item menu?

[alexbbrown]

Delving into the source code I now understand what this UI does.

its authenticatedIdentitiesMenu which displays a list of your other identities.

when provided for favourite and boost, tapping the menu has the effect of favoriting or boosting using your alt.

but this is not clear to the user because:

• there's no verb in the menu title or item
• There's no visual feedback or animation
• There's no indication that it's boosted or favorited after
• There's no indication in the menu that it's happened.

I'll close this bug and file another for the above issues