metabolist / metatext

A free, open-source iOS Mastodon client.
https://metabolist.org/metatext
GNU General Public License v3.0
726 stars 101 forks source link

Add support for default keyboard in composition view #268

Open blazer82 opened 2 years ago

blazer82 commented 2 years ago

Summary

This fixes #76 by implementing the proposed solution to make the keyboard type configurable in the app's preferences.

Other Information

alexbbrown commented 2 years ago

I think it's a mistake to include the name of the other site in this code and UI?

Let's refer to the actual user experience here, not a different branded product.

I think "keyboard with hash" would do the job.

blazer82 commented 2 years ago

I think it's a mistake to include the name of the other site in this code and UI?

@alexbbrown although it’s the official name of the keyboard, I kind of agree with you. We should come up with a better description. I’m also not that convinced of just calling the default keyboard default because in this app it’s specifically not the default. Somewhat confusing.

I’m open to suggestions.

alexbbrown commented 2 years ago

How about the UI preference selects between "Twitter style" and "System"

By analogy with the Appearance mode choice of System|Light|Dark

or alternatively focus on how the user experiences it:

Keyboard : "with #" / "with ⏎"

blazer82 commented 2 years ago

How about the UI preference selects between "Twitter style" and "System"

still has the name Twitter in it.

Keyboard : "with #" / "with ⏎"

I kinda like it but my screen reader doesn't. It just skips over the most important parts. This wouldn't be good for accessibility.

We should probably spell it out as you did with your initial suggestion: with hash / with return key Hopefully, this won't be too hard to translate to all the supported languages.