search

metaborg / rust-scopegraphs

Scope Graph Implementation in Rust
https://github.com/metaborg/rust-scopegraphs
MIT License
20 stars 0 forks source link

add 'lbl lifetime #12

Closed jdonszelmann closed 7 months ago

AZWN commented 7 months ago

PR looks good. I am a bot torn about how to deal with labels. Indeed, we got rid of the copy trait on LABEL, but the API did become a bit more complicated. Which variant would you choose?

jdonszelmann commented 7 months ago

We can also simplify using &'static here

AZWN commented 7 months ago

Hmm, I don't think using 'static has any advantages over either Copy or 'lbl.

I think using 'lbl is the most flexible option. The additional complexity is only internal, and I think we can handle that 💪 , so I'll merge this :).

Thanks for the contribution again :D.