search

metaborg / rust-scopegraphs

Scope Graph Implementation in Rust
https://github.com/metaborg/rust-scopegraphs
MIT License
20 stars 0 forks source link

Regex #4

Closed jdonszelmann closed 10 months ago

jdonszelmann commented 10 months ago

All these issues are fixed by merging #5. I love the docs!

AZWN commented 10 months ago

I think this PR is almost ready to be merged. There is the comment about nullable, but otherwise I think everything is resolved. @jdonszelmann would you agree if I do a final pass tomorrow, and merge it then?

AZWN commented 10 months ago

Something else we should still do is make the macro a bit more robust against syntax errors. E.g. by giving a default implementation ~0 when a syntax error occurs, so that the code afterwards can still properly refer to it, instead of generating a lot of cascading errors.

Jonathan: RESOLVED

jdonszelmann commented 10 months ago

I agree with merging this soon

jdonszelmann commented 10 months ago

I think all features are already on by default

AZWN commented 10 months ago

At least by adding --all-features, we ensure that remains the case in the future :)

AZWN commented 10 months ago

There is one thing that I'm not happy about yet, and that is the multiple transition tables in MatchState. I think Regex/Automaton & co. should be parameterized by the label type L, and we should support easy conversion from Regex<L> to Regex<L'> if there exists a conversion from L to L'.

I tried to do that locally, but that seems quite involved. So I propose to postpone that, and merge this for now.